CXX-3082 use from_json and make_array to simplify expectation expressions #1232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinAlbs
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #1208.
Simplifies existing bsoncxx examples by using
bsoncxx::from_json()andbsoncxx::builder::basic::make_array()in expectation expressions for final result values. These patterns help avoid the verbose two-step "check element validity" -> "obtain element value" usually required for per-element value access.The written-out JSON document is expected to be easier to read and understand by users than per-element access syntax. Examples of the form
from_json() == from_json()(demonstrating its own behavior) is avoided. Some examples still use element access syntax (particularly array examples) in cases where it is more convenient (i.e. element type expectations).