CXX-3160 Remove mongocxx::stdx #1248
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinAlbs
reviewed
Nov 1, 2024
kevinAlbs
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves CXX-3160. Verified by this patch.
The redeclaration of
bsoncxx::stdxasmongocxx::stdxhas caused ambiguities, confusion, and difficulties usingstdxinterfaces when bothbsoncxxandmongocxxare present (e.g. CXX-1060). It is unclear what the original motivation for this pattern is (CXX-716), but given its dubious value and recurring troubles, this PR proposes to remove the namespace in v4 in favor of consistently usingbsoncxx::stdxinstead.Note
The 3.11.0 release documented the
mongocxx/stdx.hppheader as "for internal use only" in #1184.