CXX-3174 Revert include-guard-conditioned macro guards in mongocxx #1262
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eramongodb
changed the title
kevinAlbs
approved these changes
Nov 11, 2024
Will leave as-is then for the r3.11 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #1202, where use of these "smart macro guards" conditioned on include guard macros was intended to be reverted (see: #1202 (comment)) but neglected to apply the changes to mongocxx headers. Reverting now for consistency. I don't expect this to have caused any issues, but nevertheless, may opt to cherry-pick onto the r3.11 branch if deemed necessary.