Skip to content

CXX-3179 Set ENABLE_TESTS=OFF by default #1266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 12, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ def tasks():
run_on=distro.name,
commands=[
InstallCDriver.call(),
Compile.call(build_type='Debug'),
Compile.call(build_type='Debug', vars={'ENABLE_TESTS': 'ON'}),
TestSearchIndexHelpers.call(),
],
)
Expand Down
1 change: 0 additions & 1 deletion .evergreen/config_generator/components/compile_only.py
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,6 @@ def generate_tasks():
build_type=build_type,
compiler=compiler,
polyfill=polyfill,
vars={'ENABLE_TESTS': 'OFF'}
)
],
)
Expand Down
10 changes: 8 additions & 2 deletions .evergreen/config_generator/components/integration.py
Original file line number Diff line number Diff line change
Expand Up @@ -105,10 +105,16 @@ def tasks():
distro = find_large_distro(distro_name)

updates = []
icd_vars = {'BSON_EXTRA_ALIGNMENT': 1} if with_extra_align else {}
compile_vars = {'BSON_EXTRA_ALIGNMENT': 1} if with_extra_align else {'RUN_DISTCHECK': 1}
icd_vars = {}
compile_vars = {'ENABLE_TESTS': 'ON'}
test_vars = {'MONGOCXX_TEST_TOPOLOGY': topology}

if with_extra_align:
icd_vars |= {'BSON_EXTRA_ALIGNMENT': 1}
compile_vars |= {'BSON_EXTRA_ALIGNMENT': 1}
else:
compile_vars |= {'RUN_DISTCHECK': 1}

updates += [KeyValueParam(key='build_type', value=build_type)]
updates += [KeyValueParam(key=key, value=value) for key, value in compiler_to_vars(compiler).items()]

Expand Down
2 changes: 1 addition & 1 deletion .evergreen/config_generator/components/mongohouse.py
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ def tasks():
commands=[
Setup.call(),
FetchCDriverSource.call(),
Compile.call(build_type='Release'),
Compile.call(build_type='Release', vars={'ENABLE_TESTS': 'ON'}),
BuildMongohouse.call(),
RunMongohouse.call(),
TestMongohouse.call(),
Expand Down
2 changes: 1 addition & 1 deletion .evergreen/config_generator/components/sanitizers.py
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ def tasks():
updates += [KeyValueParam(key=key, value=value) for key, value in compiler_to_vars(compiler).items()]

icd_vars = {'SKIP_INSTALL_LIBMONGOCRYPT': 1}
compile_vars = {}
compile_vars = {'ENABLE_TESTS': 'ON'}
test_vars = {
'MONGOCXX_TEST_TOPOLOGY': topology,
'example_projects_cc': 'clang',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,6 @@ def tasks():
Compile.call(
build_type=build_type,
compiler=compiler,
vars={'ENABLE_TESTS': 'OFF'},
),
UninstallCheck.call(),
],
Expand Down
2 changes: 1 addition & 1 deletion .evergreen/config_generator/components/valgrind.py
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ def tasks():

updates = [KeyValueParam(key='build_type', value='Debug')]
icd_vars = {'SKIP_INSTALL_LIBMONGOCRYPT': 1}
compile_vars = {}
compile_vars = {'ENABLE_TESTS': 'ON'}
test_vars = {
'MONGOCXX_TEST_TOPOLOGY': topology,
'TEST_WITH_VALGRIND': 'ON',
Expand Down
2 changes: 1 addition & 1 deletion .evergreen/config_generator/components/versioned_api.py
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ def tasks():
tags.append(polyfill)

mongod_vars |= {'AUTH': 'noauth'} # Versioned API + auth is tested by the C Driver.
compile_vars = {}
compile_vars = {'ENABLE_TESTS': 'ON'}
test_vars |= {'MONGOCXX_TEST_TOPOLOGY': 'single'}

match distro.os_type:
Expand Down
Loading