CXX-3163 Remove workarounds for core::optional<T> #1269
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinAlbs
approved these changes
Nov 12, 2024
CHANGELOG.md
Outdated
| ## Changed | ||
|
|
||
| - CMake option `ENABLE_TESTS` is now `OFF` by default. | ||
| - Set `ENABLE_TEST=ON` to re-enable building test targets. | ||
| - Set `BUILD_TESTING=ON` to include test targets in the "all" target when `ENABLE_TESTS=ON` (since 3.9.0, `OFF` by default). | ||
| - Layout of `mongocxx::v_noabi::options::change_stream` to support optional `start_at_operation_time` accessors. |
There was a problem hiding this comment.
Suggested change
| - Layout of `mongocxx::v_noabi::options::change_stream` to support optional `start_at_operation_time` accessors. | |
| - Layout of `mongocxx::v_noabi::options::change_stream` to support optional `start_at_operation_time` accessor. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves CXX-3163. Verified by this patch.
Following #1257, workarounds that were required for mnmlstc/core
optional<T>compatibility are no longer required.These former workarounds consist of improper initialization of underlying objects affecting the behavior of the type (fixed in mnmlstc/core@776eb3e but never released). The
mongocxx::v_noabi::options::change_streamclass's_start_at_operation_timedata member (and related accessors) are most notably affected by this issue and the primary change in this PR. Related workarounds in test code are also replaced.