Skip to content

Re-exclude rhel79 from compile-only matrix in patch builds #1325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 30, 2025

Conversation

eramongodb
Copy link
Contributor

@eramongodb eramongodb commented Jan 30, 2025

#1313 incorrectly reverted a patch-only workaround introduced in #1277, which unintentionally reintroduced compile-only-rhel79-release-shared-impls task failure in GitHub PR patch builds.

@eramongodb eramongodb requested a review from kevinAlbs January 30, 2025 20:27
@eramongodb eramongodb self-assigned this Jan 30, 2025
Copy link
Collaborator

@kevinAlbs kevinAlbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oop. I missed that failing task on #1313. LGTM.

@@ -61,6 +61,10 @@ def generate_tasks():
if any(pattern in distro_name for pattern in ['power8', 'zseries']):
patchable = False

# etc/calc_release_version.py: error: unknown option `--format=...'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# etc/calc_release_version.py: error: unknown option `--format=...'
# etc/calc_release_version.py: error: unknown option `format...'

To match current message.

@eramongodb eramongodb merged commit 7452f37 into mongodb:master Jan 30, 2025
1 check was pending
@eramongodb eramongodb deleted the cxx-evg-rhel79 branch January 30, 2025 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants