CXX-3251 remove workaround for big_string length in API examples #1357
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please include this fix too: 16b8e1f |
eramongodb
changed the title
|
Created CXX-3251 to track the related fix to Additionally applied a workaround for incompatible C Driver |
eramongodb
changed the title
ghost
approved these changes
Mar 21, 2025
ghost
approved these changes
Mar 21, 2025
kevinAlbs
approved these changes
Mar 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves CXX-3251. Followup to #1216. Removes the workaround for CDRIVER-5732, whose behavior was properly fixed by mongodb/mongo-c-driver#1891 (CDRIVER-5915). The proper fix now means the
- 32uworkaround is preventing the length checks which are intended to fail in API examples.This PR sets
MONGOC_VERSION_MINIMUMandLIBMONGOC_DOWNLOAD_VERSIONto mongodb/mongo-c-driver@57bffac accordingly.Important
This dependency update implies the next C++ Driver release (4.1.0) will require C Driver 2.0.0 or newer (CXX-3103). If we do not want to impose a C Driver v2 requirement on C++ Driver users (even if it is technically an ABI-only requirement), we may need to consider creating a v5.0 development branch to avoid applying the C Driver 2.0 dependency to upcoming v4 releases.