CXX-3261 sync change streams unified spec tests with 0aee4aad #1366
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or older (mongodb#1365)" This reverts commit 2e9c164.
kevinAlbs
approved these changes
Apr 2, 2025
eramongodb
added a commit
that referenced
this pull request
Apr 18, 2025
* CXX-2493 sync change streams unified spec tests with 9652564e * CXX-2493 sync change streams unified spec tests with 8da1a899 * CXX-2555 sync change streams unified spec tests with 046db449 * CXX-2570 sync change streams unified spec tests with 51741620 * CXX-2571 sync change streams unified spec tests with d9a0e7b2 * CXX-2572 sync change streams unified spec tests with 9a8abe81 * CXX-2571 sync change streams unified spec tests with 1a3b359a * CXX-2690 sync change streams unified spec tests with 474ddfcc * CXX-3211 sync change streams unified spec tests with 449d0397 * CXX-3261 sync change streams unified spec tests with 0aee4aad * CXX-2493 skip currently unsupported spec tests (showExpandedEvents)
eramongodb
added a commit
to eramongodb/mongo-cxx-driver
that referenced
this pull request
Apr 21, 2025
…db#1366) * CXX-2493 sync change streams unified spec tests with 9652564e * CXX-2493 sync change streams unified spec tests with 8da1a899 * CXX-2555 sync change streams unified spec tests with 046db449 * CXX-2570 sync change streams unified spec tests with 51741620 * CXX-2571 sync change streams unified spec tests with d9a0e7b2 * CXX-2572 sync change streams unified spec tests with 9a8abe81 * CXX-2571 sync change streams unified spec tests with 1a3b359a * CXX-2690 sync change streams unified spec tests with 474ddfcc * CXX-3211 sync change streams unified spec tests with 449d0397 * CXX-3261 sync change streams unified spec tests with 0aee4aad * CXX-2493 skip currently unsupported spec tests (showExpandedEvents)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses CXX-3261. Followup to #1365 and mongodb/mongo-c-driver#1971.
Additionally syncs change streams unified spec tests with changes implemented prior to CXX-3261.
Tickets which are fully resolved by this PR include:
Tickets which require API changes include:
showExpandedEvents)Tests which depend on CXX-2493 are skipped by this PR.
Note
We do not expose an API dedicated to representing change stream results (
changeStreamDocument) or its fields (e.g..updateDescriptionor.updateDescription.disambiguatedPaths, so spec test syncing is sufficient to resolve most of the tickets referenced above. CXX-2493 however does require the addition to dedicated API (show_expanded_events()inmongocxx::v_noabi::options::change_stream), so it is left unresolved.