Remove client arg from test helpers #1372
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Remove
client
arg from test helpers that cache results.Verified with this patch build: https://spruce.mongodb.com/version/67ee96310b754c000700e66c
Motivation
When working on CXX-3209 I was surprised to discover calling
test_util::get_max_wire_version
on a differently versionedmongocryptd
returned the same value as the runningmongod
:The cause appeared to be due to cached results in test helpers:
Later calls ignore the
client
argument. To avoid surprising readers, theclient
argument is removed from these calls. The calls always use a client constructed with the URI "mongodb://localhost:27017". Overloads accepting a client can be added later as needed.