Download and build-from-source valgrind 3.24.0 when not present #1383
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinAlbs
approved these changes
Apr 17, 2025
eramongodb
added a commit
that referenced
this pull request
Apr 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unblock ongoing Valgrind task failures while DEVPROD-16589 continues to be investigated. Proposes using a pattern similar to install_uv.py, where a recent version of Valgrind is downloaded (verified by SHA1 checksum) and built-from-source. This is meant to be a temporary solution until DEVPROD-16589 is resolved (temporary to minimize our use of
curlcommands in CI scripts). Use of a 60 second timeout for curl (-m 60) is arbitrary and may be extended if it is observed to be too short (the total download+build+install time is currently around ~60 seconds on EVG).The valgrind detection-and-download step is also moved to the front of the list of EVG commands executed (immediately after setup rather than within
test.sh) so any issues with valgrind acquisition will fail early and quickly before other wasteful execution of discarded setup tasks (i.e. install C Driver).