Skip to content

CXX-3296 fix build if GCC/GNU/Clang/MSVC macro defined #1409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
May 28, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/bsoncxx/include/bsoncxx/v1/detail/postlude.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,10 @@
#pragma pop_macro("BSONCXX_PRIVATE_WARNINGS_DISABLE")
#pragma pop_macro("BSONCXX_PRIVATE_WARNINGS_POP")
#pragma pop_macro("BSONCXX_PRIVATE_WARNINGS_PUSH")
#pragma pop_macro("Clang")
#pragma pop_macro("GCC")
#pragma pop_macro("GNU")
#pragma pop_macro("MSVC")
#endif

#if !defined(BSONCXX_PRIVATE_V1_INSIDE_MACRO_GUARD_SCOPE)
Expand Down
8 changes: 8 additions & 0 deletions src/bsoncxx/include/bsoncxx/v1/detail/prelude.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,14 @@
#undef BSONCXX_PRIVATE_WARNINGS_PUSH
#pragma push_macro("BSONCXX_PRIVATE_UNREACHABLE")
#undef BSONCXX_PRIVATE_UNREACHABLE
#pragma push_macro("Clang") // Guard since BSONCXX_PRIVATE_WARNINGS_DISABLE(Clang(...)) assumes Clang is not defined.
#undef Clang
#pragma push_macro("GCC") // Guard since BSONCXX_PRIVATE_WARNINGS_DISABLE(GCC(...)) assumes GCC is not defined.
#undef GCC
#pragma push_macro("GNU") // Guard since BSONCXX_PRIVATE_WARNINGS_DISABLE(GNU(...)) assumes GNU is not defined.
#undef GNU
#pragma push_macro("MSVC") // Guard since BSONCXX_PRIVATE_WARNINGS_DISABLE(MSVC(...)) assumes MSVC is not defined.
#undef MSVC
#endif

///
Expand Down
4 changes: 4 additions & 0 deletions src/bsoncxx/test/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,10 @@ if(ENABLE_MACRO_GUARD_TESTS)
BSONCXX_PRIVATE_WARNINGS_DISABLE_IMPL_FOR_MSVC
BSONCXX_PRIVATE_WARNINGS_POP
BSONCXX_PRIVATE_WARNINGS_PUSH
Clang
GCC
GNU
MSVC

# bsoncxx/v1/detail/prelude.hpp
BSONCXX_PRIVATE_V1_INSIDE_MACRO_GUARD_SCOPE
Expand Down