-
Notifications
You must be signed in to change notification settings - Fork 543
CXX-3302 Update bsoncxx validation examples (CDRIVER-5710, CDRIVER-6017) #1416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
7d92e88
Update examples for CDRIVER-5710 and CDRIVER-6017
eramongodb adac29e
Add missing import of ec2_assume_role
eramongodb 4284efa
Also bump the auto-downloaded C Driver version
eramongodb a3051e7
CXX-3302 bump minimum required C Driver version to 2.0.2
eramongodb b15ef1d
Update SBOM Lite
eramongodb c1740c8
Update Augmented SBOM
eramongodb File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,16 +1,16 @@ | ||
{ | ||
"components": [ | ||
{ | ||
"bom-ref": "pkg:github/mongodb/[email protected].0", | ||
"bom-ref": "pkg:github/mongodb/[email protected].2", | ||
"copyright": "Copyright 2009-present MongoDB, Inc.", | ||
"externalReferences": [ | ||
{ | ||
"type": "distribution", | ||
"url": "https://github.com/mongodb/mongo-c-driver/archive/refs/tags/v2.0.0.tar.gz" | ||
"url": "https://github.com/mongodb/mongo-c-driver/archive/refs/tags/v2.0.2.tar.gz" | ||
}, | ||
{ | ||
"type": "website", | ||
"url": "https://github.com/mongodb/mongo-c-driver/tree/v2.0.0" | ||
"url": "https://github.com/mongodb/mongo-c-driver/tree/v2.0.2" | ||
} | ||
], | ||
"group": "mongodb", | ||
|
@@ -22,18 +22,18 @@ | |
} | ||
], | ||
"name": "mongo-c-driver", | ||
"purl": "pkg:github/mongodb/[email protected].0", | ||
"purl": "pkg:github/mongodb/[email protected].2", | ||
"type": "library", | ||
"version": "v2.0.0" | ||
"version": "v2.0.2" | ||
} | ||
], | ||
"dependencies": [ | ||
{ | ||
"ref": "pkg:github/mongodb/[email protected].0" | ||
"ref": "pkg:github/mongodb/[email protected].2" | ||
} | ||
], | ||
"metadata": { | ||
"timestamp": "2025-04-02T19:47:45.682404+00:00", | ||
"timestamp": "2025-06-12T17:36:20.890153+00:00", | ||
"tools": [ | ||
{ | ||
"externalReferences": [ | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,16 +1,16 @@ | ||
{ | ||
"components": [ | ||
{ | ||
"bom-ref": "pkg:github/mongodb/[email protected].0", | ||
"bom-ref": "pkg:github/mongodb/[email protected].2", | ||
"copyright": "Copyright 2009-present MongoDB, Inc.", | ||
"externalReferences": [ | ||
{ | ||
"type": "distribution", | ||
"url": "https://github.com/mongodb/mongo-c-driver/archive/refs/tags/v2.0.0.tar.gz" | ||
"url": "https://github.com/mongodb/mongo-c-driver/archive/refs/tags/v2.0.2.tar.gz" | ||
}, | ||
{ | ||
"type": "website", | ||
"url": "https://github.com/mongodb/mongo-c-driver/tree/v2.0.0" | ||
"url": "https://github.com/mongodb/mongo-c-driver/tree/v2.0.2" | ||
} | ||
], | ||
"group": "mongodb", | ||
|
@@ -22,18 +22,18 @@ | |
} | ||
], | ||
"name": "mongo-c-driver", | ||
"purl": "pkg:github/mongodb/[email protected].0", | ||
"purl": "pkg:github/mongodb/[email protected].2", | ||
"type": "library", | ||
"version": "v2.0.0" | ||
"version": "v2.0.2" | ||
} | ||
], | ||
"dependencies": [ | ||
{ | ||
"ref": "pkg:github/mongodb/[email protected].0" | ||
"ref": "pkg:github/mongodb/[email protected].2" | ||
} | ||
], | ||
"metadata": { | ||
"timestamp": "2025-05-01T20:23:28.401764+00:00", | ||
"timestamp": "2025-06-12T17:36:20.890153+00:00", | ||
"tools": [ | ||
{ | ||
"externalReferences": [ | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,4 +6,4 @@ | |
# re-generate the SBOM JSON file! | ||
|
||
# bson and mongoc may be obtained via cmake/FetchMongoC.cmake. | ||
pkg:github/mongodb/[email protected].0 | ||
pkg:github/mongodb/[email protected].2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am open to debate, but I slightly prefer bumping the minimum required version to 2.0.2.
I see three distinct versions:
MONGOC_VERSION_MINIMUM
is the tested version in CI.MONGOC_DOWNLOAD_VERSION
is the automatically downloaded version.MONGOC_REQUIRED_VERSION
is the required version.I expect these do not strictly need to match, as is proposed in this PR. However, only bumping tested+downloaded means tests fail with the minimum required C driver. That may be unlikely to impact users, but bumping all to 2.0.2 avoids the possibility. The other benefit: upgrading to C++ driver 4.1.0 (with minimum C driver 2.0.2) is guaranteed to have the bug fix of CDRIVER-6017.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. Included a reference to CXX-3302 for tracking purposes.