Skip to content

CXX-2614 sync tests impacted by removal of MONGODB-CR #911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 15, 2022

Conversation

kevinAlbs
Copy link
Collaborator

Summary

@kevinAlbs kevinAlbs marked this pull request as ready for review December 15, 2022 17:53
@kevinAlbs kevinAlbs requested a review from eramongodb December 15, 2022 17:53
@eramongodb
Copy link
Contributor

@codecov-commenter
Copy link

Codecov Report

Merging #911 (81318fc) into master (0b6488f) will decrease coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #911      +/-   ##
==========================================
- Coverage   91.28%   91.23%   -0.05%     
==========================================
  Files         384      384              
  Lines       23275    23275              
==========================================
- Hits        21246    21236      -10     
- Misses       2029     2039      +10     
Impacted Files Coverage Δ
src/mongocxx/options/change_stream.cpp 93.84% <0.00%> (-4.62%) ⬇️
src/bsoncxx/test_util/to_string.hh 43.63% <0.00%> (-3.64%) ⬇️
src/mongocxx/private/index_view.hh 94.17% <0.00%> (-0.98%) ⬇️
src/mongocxx/test/index_view.cpp 98.20% <0.00%> (-0.72%) ⬇️
...rc/mongocxx/test/spec/unified_tests/operations.cpp 86.85% <0.00%> (-0.19%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@kevinAlbs
Copy link
Collaborator Author

Should src/libmongoc/tests/json/command_monitoring/unified/redacted-commands.json also be synced with source/command-logging-and-monitoring/tests/monitoring/redacted-commands.json?

Yes, that is updated in this PR: mongodb/mongo-c-driver#1165

Copy link
Contributor

@eramongodb eramongodb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confused by where the line removal diffs in redacted-commands.json is coming from, but otherwise LGTM.

@kevinAlbs
Copy link
Collaborator Author

Confused by where the line removal diffs in redacted-commands.json is coming from, but otherwise LGTM.

The authenticate-without-observing test may have been added in the C++ driver when initially included by @vector-of-bool here: b23a3b8#diff-3930ed09d0bf0a45e7af7cfab4f3f5332d34fc5ba1724185358ee83ffdee85e8R95

I want to keep the test matching the specifications. The authenticate-without-observing test appears to test the behavior when observeSensitiveCommands=false. That is also tested in the observeSensitiveCommands tests.

@kevinAlbs kevinAlbs merged commit a10c3f0 into mongodb:master Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants