Skip to content

CXX-2612 Use DET hygienic scripts for Python binary selection and venv creation #913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Dec 19, 2022

Conversation

eramongodb
Copy link
Contributor

@eramongodb eramongodb commented Dec 16, 2022

This PR addresses CXX-2612, motivated by ongoing task failures due to ImportError: No module named functools_lru_cache when evaluating the start_mongod Evergreen function.

Verified by this patch, which depends on a custom DET branch with features pending review in mongodb-labs/drivers-evergreen-tools#255. This PR will be moved out of draft status once the DET pull request has been merged.

@eramongodb eramongodb self-assigned this Dec 16, 2022
@eramongodb eramongodb marked this pull request as draft December 16, 2022 17:46
@codecov-commenter
Copy link

codecov-commenter commented Dec 16, 2022

Codecov Report

Merging #913 (60ca2ff) into master (a10c3f0) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #913   +/-   ##
=======================================
  Coverage   91.28%   91.28%           
=======================================
  Files         384      384           
  Lines       23275    23275           
=======================================
  Hits        21246    21246           
  Misses       2029     2029           
Impacted Files Coverage Δ
src/mongocxx/test/collection.cpp 97.32% <100.00%> (ø)
src/mongocxx/test/uri.cpp 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@kevinAlbs
Copy link
Collaborator

To fix the Windows tasks the workaround from the C driver may be needed to avoid the "Failed to initialize security context" error.

@eramongodb eramongodb marked this pull request as ready for review December 16, 2022 22:34
@eramongodb
Copy link
Contributor Author

Verified latest commits with this patch. The CSE task failures appears to have been due to the special casing of defining MONGOCXX_TEST_CSFLE_TLS_CA_FILE and MONGOCXX_TEST_CSFLE_TLS_CERTIFICATE_KEY_FILE on Windows using backslashes instead of forward slashes. This may warrant further investigation as a followup to ensure a more sensible error message is emitted given (supposedly) an incorrect path to CA/cert files on Windows.

@eramongodb eramongodb requested a review from kevinAlbs December 19, 2022 16:49
@eramongodb eramongodb merged commit 548610c into mongodb:master Dec 19, 2022
@eramongodb eramongodb deleted the cxx-2612 branch December 19, 2022 18:37
@eramongodb eramongodb changed the title CXX-2162 Use DET hygienic scripts for Python binary selection and venv creation CXX-2612 Use DET hygienic scripts for Python binary selection and venv creation Dec 19, 2022
rcsanchez97 pushed a commit that referenced this pull request Mar 7, 2023
…v creation (#913)

* Replace activate_venv.sh with activate-kmstlsvenv.sh

* Replace manual Python selection in compile function

* Use venv-utils.sh in stop_mongod function

* Format collection.cpp and uri.cpp to address lint task failure

* Guard cd to potentially missing DET repo

* CXX-2628 Apply Python >=3.10 selection workaround used by C Driver

* Remove special-casing of TLS test cert files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants