Opt in to the default CMake install path #994
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…SE_DEFAULT_INSTALL_PATH=ON
kkloberdanz
force-pushed
the
use-cmake-default-install
branch
from
4893307 to
48aa1e1
Compare
kevinAlbs
reviewed
Jul 27, 2023
| message(FATAL_ERROR "You cannot set both CMAKE_INSTALL_PREFIX and USE_DEFAULT_INSTALL_PATH") | ||
| endif() | ||
| if(CMAKE_INSTALL_PREFIX_INITIALIZED_TO_DEFAULT AND NOT USE_DEFAULT_INSTALL_PATH) | ||
| message(WARNING "the CMake default install path is being overriden. This behavior will not be the default in a future release. Build with -DUSE_DEFAULT_INSTALL_PATH=ON to opt into what will be the default behavior in a future release") | ||
| set (CMAKE_INSTALL_PREFIX "${CMAKE_BINARY_DIR}/install" CACHE PATH "default install path" FORCE) | ||
| endif() |
There was a problem hiding this comment.
Update the Configure the driver steps in the install documentation to use the USE_DEFAULT_INSTALL_PATH option.
Co-authored-by: Kevin Albertson <[email protected]>
kevinAlbs
approved these changes
Jul 27, 2023
rcsanchez97
approved these changes
Jul 27, 2023
| # set it to live under build so we don't inadvertently pollute /usr/local | ||
| if(CMAKE_INSTALL_PREFIX_INITIALIZED_TO_DEFAULT) | ||
| option(USE_DEFAULT_INSTALL_PATH "Override the CMake default installation path" OFF) | ||
| if(NOT CMAKE_INSTALL_PREFIX_INITIALIZED_TO_DEFAULT AND USE_DEFAULT_INSTALL_PATH) |
There was a problem hiding this comment.
CMAKE_INSTALL_PREFIX_INITIALIZED_TO_DEFAULT is only TRUE on the very first execution of configure, so setting USE_DEFAULT_INSTALL_PATH=TRUE will trigger this branch on every subsequent configure, preventing it from succeeding until CMAKE_INSTALL_PREFIX is un-set on the CLI with -U.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CXX-2703
Allow user to opt in to the default CMake install path by setting
-DUSE_DEFAULT_INSTALL_PATH=ON