GODRIVER-1560 Ensure there is no default idle connection timeout (#369)

Author: Divjot Arora

x/mongo/driver/topology/connection.go

@@ -305,9 +305,11 @@ func (c *connection) close() error {
 
 func (c *connection) expired() bool {
 	now := time.Now()
-	idleDeadline, ok := c.idleDeadline.Load().(time.Time)
-	if ok && now.After(idleDeadline) {
-		return true
+	if c.idleTimeout > 0 {
+		idleDeadline, ok := c.idleDeadline.Load().(time.Time)
+		if ok && now.After(idleDeadline) {
+			return true
+		}
 	}
 
 	if !c.lifetimeDeadline.IsZero() && now.After(c.lifetimeDeadline) {

x/mongo/driver/topology/connection_options.go

@@ -56,7 +56,6 @@ func newConnectionConfig(opts ...ConnectionOption) (*connectionConfig, error) {
 	cfg := &connectionConfig{
 		connectTimeout: 30 * time.Second,
 		dialer:         nil,
-		idleTimeout:    10 * time.Minute,
 		lifeTimeout:    30 * time.Minute,
 	}
 

x/mongo/driver/topology/connection_test.go

@@ -15,6 +15,7 @@ import (
 	"time"
 
 	"github.com/google/go-cmp/cmp"
+	"go.mongodb.org/mongo-driver/internal/testutil/assert"
 	"go.mongodb.org/mongo-driver/x/mongo/driver"
 	"go.mongodb.org/mongo-driver/x/mongo/driver/address"
 	"go.mongodb.org/mongo-driver/x/mongo/driver/description"
@@ -45,6 +46,13 @@ func TestConnection(t *testing.T) {
 					t.Errorf("errors do not match. got %v; want %v", got, want)
 				}
 			})
+			t.Run("no default idle timeout", func(t *testing.T) {
+				conn, err := newConnection(context.Background(), address.Address(""))
+				assert.Nil(t, err, "newConnection error: %v", err)
+				wantTimeout := time.Duration(0)
+				assert.Equal(t, wantTimeout, conn.idleTimeout, "expected idle timeout %v, got %v", wantTimeout,
+					conn.idleTimeout)
+			})
 		})
 		t.Run("connect", func(t *testing.T) {
 			t.Run("dialer error", func(t *testing.T) {