Skip to content

fix bson regex compare #318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 2, 2020
Merged

fix bson regex compare #318

merged 1 commit into from
Mar 2, 2020

Conversation

mengskysama
Copy link
Contributor

No description provided.

@divjotarora
Copy link
Contributor

Hi @mengskysama,

Thank you for your contribution to the driver! The code changes look good. Can you add a test to primitive_test.go? I think we would need one top-level test with four subtests that compare two primitive.Regex instances:

  1. Both Pattern and Options fields equal
  2. Pattern fields equal, Options fields different
  3. Pattern fields different, Options fields equal
  4. Both Pattern and Options fields different

You can take inspiration from https://github.com/mongodb/mongo-go-driver/blob/master/bson/primitive/primitive_test.go#L20 to write these tests as a table. Also, if you don't have the time to add these test cases, let us know via a comment and we can take over to write them for you.

Thanks,

-- Divjot

@mengskysama mengskysama force-pushed the patch-1 branch 2 times, most recently from c3becd8 to d673c8e Compare March 2, 2020 15:59
@mengskysama
Copy link
Contributor Author

PTAL

@divjotarora
Copy link
Contributor

@mengskysama There is an fmt failure in the test file because the struct fields are not aligned. Can you run gofmt -s -w bson/primitive/primitive_test.go or manually fix the field types to be aligned with "string"?

@divjotarora divjotarora self-requested a review March 2, 2020 16:25
@mengskysama
Copy link
Contributor Author

@divjotarora it fixed now :)

@divjotarora divjotarora merged commit 9b8eb61 into mongodb:master Mar 2, 2020
@divjotarora
Copy link
Contributor

@mengskysama I've merged your patch and I'll backport it to the release/1.3 branch so it will be included in the upcoming 1.3.1 release. Once again, thank you for your contribution!

divjotarora pushed a commit that referenced this pull request Mar 2, 2020
@mengskysama
Fix primitive.Regex Equal method (#318)
38d59c3
@divjotarora
Copy link
Contributor

This commit has been backported to the release/1.3 branch.

kpatel71716 added a commit to mongodb-forks/mongo-go-driver that referenced this pull request Sep 2, 2020
@kpatel71716 @mengskysama
@cvluca @haleyowen @edaniels @tkaye407 @jbreams @mpobrien
REALMC-5872 merging topology changes to v1.4.1 driver (#1)
c59bda0 
* Update version to v1.3.1+prerelease

* Change w value for unsatisfiable write concern in tests (mongodb#301)

- Addresses test failures that started after by SERVER-45920

* GODRIVER-895 check if strLength is 0 in ReadCodeWithScope (mongodb#311)

* GODRIVER-1487 fix adding UnknownTransactionCommitResult (mongodb#307)

* GODRIVER-1488 turn off DecodeDeepZeroInline for mgocompat.Registry (mongodb#312)

* Fix primitive.Regex Equal method (mongodb#318)

* GODRIVER-1507 Correctly pass URI to topology (mongodb#320)

* Update version to 1.3.1

* Update version to v1.3.2+prerelease

* GODRIVER-1522 Ignore read preference for aggregations with output stages (mongodb#327)

* GODRIVER-1520 Fix panics for lone scope (mongodb#331)

* GODRIVER-1532 Remove check when decoding invalid UTF-8 strings (mongodb#333)

* Fix typo in objectid.go (mongodb#335)

* GODRIVER-1502 Fix variable shadowing in parsing (mongodb#332)

* GODRIVER-1506 Fix error checking for invalid extjson timestamp values (mongodb#337)

* GODRIVER-1504 Restrict top-level keys from being parsed as extjson (mongodb#340)

* GODRIVER-1513 Disallow escaped single quotes in extjson keys (mongodb#342)

* GODRIVER-1535 Fix session IDs batching in Disconnect

* GODRIVER-1540 fix deadlock in connection (mongodb#348)

* GODRIVER-1549 Select all servers when an empty tag set is given (mongodb#352)

* GODRIVER-1431 Add explicit encryption examples (mongodb#350)

* Update version to v1.3.2

* STITCH-4296: Export contextWithSession

* STITCH-4296: Export sessionFromContext

* STITCH-4680 - expose topology consistency

* STITCH-4841: Add FullDocumentBeforeChange option to Mongo-go-driver

* GODRIVER-672 Change session IDs to be stored as bson.Raw (mongodb#339)

(cherry picked from commit d080bd0)

* do not leak cancelConnectContext

* REALMC-5872 renaming NewSessionContext to ContextWithSession

* REALMC-5872 adding back size check in pool test

* REALMC-5872 removing unused IsConsistent topology function and renaming changed vars

Co-authored-by: Divjot Arora <[email protected]>
Co-authored-by: iwysiu <[email protected]>
Co-authored-by: mengskysama <[email protected]>
Co-authored-by: Luca(Wei) Chen <[email protected]>
Co-authored-by: Haley Owen <[email protected]>
Co-authored-by: Eric Daniels <[email protected]>
Co-authored-by: Tyler Kaye <[email protected]>
Co-authored-by: Jonathan Reams <[email protected]>
Co-authored-by: mike o'brien <[email protected]>
tsedgwick pushed a commit to mongodb-forks/mongo-go-driver that referenced this pull request May 4, 2021
@kpatel71716 @mengskysama
@cvluca @haleyowen @edaniels @tkaye407 @jbreams @mpobrien @tsedgwick
REALMC-5872 merging topology changes to v1.4.1 driver (#1)
d56e31a 
* Update version to v1.3.1+prerelease

* Change w value for unsatisfiable write concern in tests (mongodb#301)

- Addresses test failures that started after by SERVER-45920

* GODRIVER-895 check if strLength is 0 in ReadCodeWithScope (mongodb#311)

* GODRIVER-1487 fix adding UnknownTransactionCommitResult (mongodb#307)

* GODRIVER-1488 turn off DecodeDeepZeroInline for mgocompat.Registry (mongodb#312)

* Fix primitive.Regex Equal method (mongodb#318)

* GODRIVER-1507 Correctly pass URI to topology (mongodb#320)

* Update version to 1.3.1

* Update version to v1.3.2+prerelease

* GODRIVER-1522 Ignore read preference for aggregations with output stages (mongodb#327)

* GODRIVER-1520 Fix panics for lone scope (mongodb#331)

* GODRIVER-1532 Remove check when decoding invalid UTF-8 strings (mongodb#333)

* Fix typo in objectid.go (mongodb#335)

* GODRIVER-1502 Fix variable shadowing in parsing (mongodb#332)

* GODRIVER-1506 Fix error checking for invalid extjson timestamp values (mongodb#337)

* GODRIVER-1504 Restrict top-level keys from being parsed as extjson (mongodb#340)

* GODRIVER-1513 Disallow escaped single quotes in extjson keys (mongodb#342)

* GODRIVER-1535 Fix session IDs batching in Disconnect

* GODRIVER-1540 fix deadlock in connection (mongodb#348)

* GODRIVER-1549 Select all servers when an empty tag set is given (mongodb#352)

* GODRIVER-1431 Add explicit encryption examples (mongodb#350)

* Update version to v1.3.2

* STITCH-4296: Export contextWithSession

* STITCH-4296: Export sessionFromContext

* STITCH-4680 - expose topology consistency

* STITCH-4841: Add FullDocumentBeforeChange option to Mongo-go-driver

* GODRIVER-672 Change session IDs to be stored as bson.Raw (mongodb#339)

(cherry picked from commit d080bd0)

* do not leak cancelConnectContext

* REALMC-5872 renaming NewSessionContext to ContextWithSession

* REALMC-5872 adding back size check in pool test

* REALMC-5872 removing unused IsConsistent topology function and renaming changed vars

Co-authored-by: Divjot Arora <[email protected]>
Co-authored-by: iwysiu <[email protected]>
Co-authored-by: mengskysama <[email protected]>
Co-authored-by: Luca(Wei) Chen <[email protected]>
Co-authored-by: Haley Owen <[email protected]>
Co-authored-by: Eric Daniels <[email protected]>
Co-authored-by: Tyler Kaye <[email protected]>
Co-authored-by: Jonathan Reams <[email protected]>
Co-authored-by: mike o'brien <[email protected]>
tsedgwick pushed a commit to mongodb-forks/mongo-go-driver that referenced this pull request May 4, 2021
@kpatel71716 @mengskysama
@cvluca @haleyowen @edaniels @tkaye407 @jbreams @mpobrien @tsedgwick
REALMC-5872 merging topology changes to v1.4.1 driver (#1)
d7043e1 
* Update version to v1.3.1+prerelease

* Change w value for unsatisfiable write concern in tests (mongodb#301)

- Addresses test failures that started after by SERVER-45920

* GODRIVER-895 check if strLength is 0 in ReadCodeWithScope (mongodb#311)

* GODRIVER-1487 fix adding UnknownTransactionCommitResult (mongodb#307)

* GODRIVER-1488 turn off DecodeDeepZeroInline for mgocompat.Registry (mongodb#312)

* Fix primitive.Regex Equal method (mongodb#318)

* GODRIVER-1507 Correctly pass URI to topology (mongodb#320)

* Update version to 1.3.1

* Update version to v1.3.2+prerelease

* GODRIVER-1522 Ignore read preference for aggregations with output stages (mongodb#327)

* GODRIVER-1520 Fix panics for lone scope (mongodb#331)

* GODRIVER-1532 Remove check when decoding invalid UTF-8 strings (mongodb#333)

* Fix typo in objectid.go (mongodb#335)

* GODRIVER-1502 Fix variable shadowing in parsing (mongodb#332)

* GODRIVER-1506 Fix error checking for invalid extjson timestamp values (mongodb#337)

* GODRIVER-1504 Restrict top-level keys from being parsed as extjson (mongodb#340)

* GODRIVER-1513 Disallow escaped single quotes in extjson keys (mongodb#342)

* GODRIVER-1535 Fix session IDs batching in Disconnect

* GODRIVER-1540 fix deadlock in connection (mongodb#348)

* GODRIVER-1549 Select all servers when an empty tag set is given (mongodb#352)

* GODRIVER-1431 Add explicit encryption examples (mongodb#350)

* Update version to v1.3.2

* STITCH-4296: Export contextWithSession

* STITCH-4296: Export sessionFromContext

* STITCH-4680 - expose topology consistency

* STITCH-4841: Add FullDocumentBeforeChange option to Mongo-go-driver

* GODRIVER-672 Change session IDs to be stored as bson.Raw (mongodb#339)

(cherry picked from commit d080bd0)

* do not leak cancelConnectContext

* REALMC-5872 renaming NewSessionContext to ContextWithSession

* REALMC-5872 adding back size check in pool test

* REALMC-5872 removing unused IsConsistent topology function and renaming changed vars

Co-authored-by: Divjot Arora <[email protected]>
Co-authored-by: iwysiu <[email protected]>
Co-authored-by: mengskysama <[email protected]>
Co-authored-by: Luca(Wei) Chen <[email protected]>
Co-authored-by: Haley Owen <[email protected]>
Co-authored-by: Eric Daniels <[email protected]>
Co-authored-by: Tyler Kaye <[email protected]>
Co-authored-by: Jonathan Reams <[email protected]>
Co-authored-by: mike o'brien <[email protected]>
(cherry picked from commit c59bda0)
tsedgwick added a commit to mongodb-forks/mongo-go-driver that referenced this pull request May 4, 2021
@tsedgwick @kpatel71716
REALMC-8848: upgrade to latest go driver release (#4)
27e2204 
* REALMC-5872 merging topology changes to v1.4.1 driver (#1)

* Update version to v1.3.1+prerelease

* Change w value for unsatisfiable write concern in tests (mongodb#301)

- Addresses test failures that started after by SERVER-45920

* GODRIVER-895 check if strLength is 0 in ReadCodeWithScope (mongodb#311)

* GODRIVER-1487 fix adding UnknownTransactionCommitResult (mongodb#307)

* GODRIVER-1488 turn off DecodeDeepZeroInline for mgocompat.Registry (mongodb#312)

* Fix primitive.Regex Equal method (mongodb#318)

* GODRIVER-1507 Correctly pass URI to topology (mongodb#320)

* Update version to 1.3.1

* Update version to v1.3.2+prerelease

* GODRIVER-1522 Ignore read preference for aggregations with output stages (mongodb#327)

* GODRIVER-1520 Fix panics for lone scope (mongodb#331)

* GODRIVER-1532 Remove check when decoding invalid UTF-8 strings (mongodb#333)

* Fix typo in objectid.go (mongodb#335)

* GODRIVER-1502 Fix variable shadowing in parsing (mongodb#332)

* GODRIVER-1506 Fix error checking for invalid extjson timestamp values (mongodb#337)

* GODRIVER-1504 Restrict top-level keys from being parsed as extjson (mongodb#340)

* GODRIVER-1513 Disallow escaped single quotes in extjson keys (mongodb#342)

* GODRIVER-1535 Fix session IDs batching in Disconnect

* GODRIVER-1540 fix deadlock in connection (mongodb#348)

* GODRIVER-1549 Select all servers when an empty tag set is given (mongodb#352)

* GODRIVER-1431 Add explicit encryption examples (mongodb#350)

* Update version to v1.3.2

* STITCH-4296: Export contextWithSession

* STITCH-4296: Export sessionFromContext

* STITCH-4680 - expose topology consistency

* STITCH-4841: Add FullDocumentBeforeChange option to Mongo-go-driver

* GODRIVER-672 Change session IDs to be stored as bson.Raw (mongodb#339)

(cherry picked from commit d080bd0)

* do not leak cancelConnectContext

* REALMC-5872 renaming NewSessionContext to ContextWithSession

* REALMC-5872 adding back size check in pool test

* REALMC-5872 removing unused IsConsistent topology function and renaming changed vars

Co-authored-by: Divjot Arora <[email protected]>
Co-authored-by: iwysiu <[email protected]>
Co-authored-by: mengskysama <[email protected]>
Co-authored-by: Luca(Wei) Chen <[email protected]>
Co-authored-by: Haley Owen <[email protected]>
Co-authored-by: Eric Daniels <[email protected]>
Co-authored-by: Tyler Kaye <[email protected]>
Co-authored-by: Jonathan Reams <[email protected]>
Co-authored-by: mike o'brien <[email protected]>
(cherry picked from commit c59bda0)

* REALMC-6991: add topology check

Co-authored-by: Kush Patel <[email protected]>
tsedgwick added a commit to mongodb-forks/mongo-go-driver that referenced this pull request May 27, 2021
@tsedgwick @kpatel71716
REALMC-8848: upgrade to latest go driver release (#4)
b27d575 
* REALMC-5872 merging topology changes to v1.4.1 driver (#1)

* Update version to v1.3.1+prerelease

* Change w value for unsatisfiable write concern in tests (mongodb#301)

- Addresses test failures that started after by SERVER-45920

* GODRIVER-895 check if strLength is 0 in ReadCodeWithScope (mongodb#311)

* GODRIVER-1487 fix adding UnknownTransactionCommitResult (mongodb#307)

* GODRIVER-1488 turn off DecodeDeepZeroInline for mgocompat.Registry (mongodb#312)

* Fix primitive.Regex Equal method (mongodb#318)

* GODRIVER-1507 Correctly pass URI to topology (mongodb#320)

* Update version to 1.3.1

* Update version to v1.3.2+prerelease

* GODRIVER-1522 Ignore read preference for aggregations with output stages (mongodb#327)

* GODRIVER-1520 Fix panics for lone scope (mongodb#331)

* GODRIVER-1532 Remove check when decoding invalid UTF-8 strings (mongodb#333)

* Fix typo in objectid.go (mongodb#335)

* GODRIVER-1502 Fix variable shadowing in parsing (mongodb#332)

* GODRIVER-1506 Fix error checking for invalid extjson timestamp values (mongodb#337)

* GODRIVER-1504 Restrict top-level keys from being parsed as extjson (mongodb#340)

* GODRIVER-1513 Disallow escaped single quotes in extjson keys (mongodb#342)

* GODRIVER-1535 Fix session IDs batching in Disconnect

* GODRIVER-1540 fix deadlock in connection (mongodb#348)

* GODRIVER-1549 Select all servers when an empty tag set is given (mongodb#352)

* GODRIVER-1431 Add explicit encryption examples (mongodb#350)

* Update version to v1.3.2

* STITCH-4296: Export contextWithSession

* STITCH-4296: Export sessionFromContext

* STITCH-4680 - expose topology consistency

* STITCH-4841: Add FullDocumentBeforeChange option to Mongo-go-driver

* GODRIVER-672 Change session IDs to be stored as bson.Raw (mongodb#339)

(cherry picked from commit d080bd0)

* do not leak cancelConnectContext

* REALMC-5872 renaming NewSessionContext to ContextWithSession

* REALMC-5872 adding back size check in pool test

* REALMC-5872 removing unused IsConsistent topology function and renaming changed vars

Co-authored-by: Divjot Arora <[email protected]>
Co-authored-by: iwysiu <[email protected]>
Co-authored-by: mengskysama <[email protected]>
Co-authored-by: Luca(Wei) Chen <[email protected]>
Co-authored-by: Haley Owen <[email protected]>
Co-authored-by: Eric Daniels <[email protected]>
Co-authored-by: Tyler Kaye <[email protected]>
Co-authored-by: Jonathan Reams <[email protected]>
Co-authored-by: mike o'brien <[email protected]>
(cherry picked from commit c59bda0)

* REALMC-6991: add topology check

Co-authored-by: Kush Patel <[email protected]>
tsedgwick added a commit to mongodb-forks/mongo-go-driver that referenced this pull request Jun 1, 2021
@tsedgwick @kpatel71716
REALMC-8848: upgrade to latest go driver release (#4)
e926f89 
* REALMC-5872 merging topology changes to v1.4.1 driver (#1)

* Update version to v1.3.1+prerelease

* Change w value for unsatisfiable write concern in tests (mongodb#301)

- Addresses test failures that started after by SERVER-45920

* GODRIVER-895 check if strLength is 0 in ReadCodeWithScope (mongodb#311)

* GODRIVER-1487 fix adding UnknownTransactionCommitResult (mongodb#307)

* GODRIVER-1488 turn off DecodeDeepZeroInline for mgocompat.Registry (mongodb#312)

* Fix primitive.Regex Equal method (mongodb#318)

* GODRIVER-1507 Correctly pass URI to topology (mongodb#320)

* Update version to 1.3.1

* Update version to v1.3.2+prerelease

* GODRIVER-1522 Ignore read preference for aggregations with output stages (mongodb#327)

* GODRIVER-1520 Fix panics for lone scope (mongodb#331)

* GODRIVER-1532 Remove check when decoding invalid UTF-8 strings (mongodb#333)

* Fix typo in objectid.go (mongodb#335)

* GODRIVER-1502 Fix variable shadowing in parsing (mongodb#332)

* GODRIVER-1506 Fix error checking for invalid extjson timestamp values (mongodb#337)

* GODRIVER-1504 Restrict top-level keys from being parsed as extjson (mongodb#340)

* GODRIVER-1513 Disallow escaped single quotes in extjson keys (mongodb#342)

* GODRIVER-1535 Fix session IDs batching in Disconnect

* GODRIVER-1540 fix deadlock in connection (mongodb#348)

* GODRIVER-1549 Select all servers when an empty tag set is given (mongodb#352)

* GODRIVER-1431 Add explicit encryption examples (mongodb#350)

* Update version to v1.3.2

* STITCH-4296: Export contextWithSession

* STITCH-4296: Export sessionFromContext

* STITCH-4680 - expose topology consistency

* STITCH-4841: Add FullDocumentBeforeChange option to Mongo-go-driver

* GODRIVER-672 Change session IDs to be stored as bson.Raw (mongodb#339)

(cherry picked from commit d080bd0)

* do not leak cancelConnectContext

* REALMC-5872 renaming NewSessionContext to ContextWithSession

* REALMC-5872 adding back size check in pool test

* REALMC-5872 removing unused IsConsistent topology function and renaming changed vars

Co-authored-by: Divjot Arora <[email protected]>
Co-authored-by: iwysiu <[email protected]>
Co-authored-by: mengskysama <[email protected]>
Co-authored-by: Luca(Wei) Chen <[email protected]>
Co-authored-by: Haley Owen <[email protected]>
Co-authored-by: Eric Daniels <[email protected]>
Co-authored-by: Tyler Kaye <[email protected]>
Co-authored-by: Jonathan Reams <[email protected]>
Co-authored-by: mike o'brien <[email protected]>
(cherry picked from commit c59bda0)

* REALMC-6991: add topology check

Co-authored-by: Kush Patel <[email protected]>
tsedgwick added a commit to mongodb-forks/mongo-go-driver that referenced this pull request Jun 1, 2021
@tsedgwick @kpatel71716
REALMC-8848: upgrade to latest go driver release (#4)
0da2115 
* REALMC-5872 merging topology changes to v1.4.1 driver (#1)

* Update version to v1.3.1+prerelease

* Change w value for unsatisfiable write concern in tests (mongodb#301)

- Addresses test failures that started after by SERVER-45920

* GODRIVER-895 check if strLength is 0 in ReadCodeWithScope (mongodb#311)

* GODRIVER-1487 fix adding UnknownTransactionCommitResult (mongodb#307)

* GODRIVER-1488 turn off DecodeDeepZeroInline for mgocompat.Registry (mongodb#312)

* Fix primitive.Regex Equal method (mongodb#318)

* GODRIVER-1507 Correctly pass URI to topology (mongodb#320)

* Update version to 1.3.1

* Update version to v1.3.2+prerelease

* GODRIVER-1522 Ignore read preference for aggregations with output stages (mongodb#327)

* GODRIVER-1520 Fix panics for lone scope (mongodb#331)

* GODRIVER-1532 Remove check when decoding invalid UTF-8 strings (mongodb#333)

* Fix typo in objectid.go (mongodb#335)

* GODRIVER-1502 Fix variable shadowing in parsing (mongodb#332)

* GODRIVER-1506 Fix error checking for invalid extjson timestamp values (mongodb#337)

* GODRIVER-1504 Restrict top-level keys from being parsed as extjson (mongodb#340)

* GODRIVER-1513 Disallow escaped single quotes in extjson keys (mongodb#342)

* GODRIVER-1535 Fix session IDs batching in Disconnect

* GODRIVER-1540 fix deadlock in connection (mongodb#348)

* GODRIVER-1549 Select all servers when an empty tag set is given (mongodb#352)

* GODRIVER-1431 Add explicit encryption examples (mongodb#350)

* Update version to v1.3.2

* STITCH-4296: Export contextWithSession

* STITCH-4296: Export sessionFromContext

* STITCH-4680 - expose topology consistency

* STITCH-4841: Add FullDocumentBeforeChange option to Mongo-go-driver

* GODRIVER-672 Change session IDs to be stored as bson.Raw (mongodb#339)

(cherry picked from commit d080bd0)

* do not leak cancelConnectContext

* REALMC-5872 renaming NewSessionContext to ContextWithSession

* REALMC-5872 adding back size check in pool test

* REALMC-5872 removing unused IsConsistent topology function and renaming changed vars

Co-authored-by: Divjot Arora <[email protected]>
Co-authored-by: iwysiu <[email protected]>
Co-authored-by: mengskysama <[email protected]>
Co-authored-by: Luca(Wei) Chen <[email protected]>
Co-authored-by: Haley Owen <[email protected]>
Co-authored-by: Eric Daniels <[email protected]>
Co-authored-by: Tyler Kaye <[email protected]>
Co-authored-by: Jonathan Reams <[email protected]>
Co-authored-by: mike o'brien <[email protected]>
(cherry picked from commit c59bda0)

* REALMC-6991: add topology check

Co-authored-by: Kush Patel <[email protected]>
tsedgwick added a commit to mongodb-forks/mongo-go-driver that referenced this pull request Jun 1, 2021
@tsedgwick @kpatel71716
REALMC-8848: upgrade to latest go driver release (#4)
d798d1e 
* REALMC-5872 merging topology changes to v1.4.1 driver (#1)

* Update version to v1.3.1+prerelease

* Change w value for unsatisfiable write concern in tests (mongodb#301)

- Addresses test failures that started after by SERVER-45920

* GODRIVER-895 check if strLength is 0 in ReadCodeWithScope (mongodb#311)

* GODRIVER-1487 fix adding UnknownTransactionCommitResult (mongodb#307)

* GODRIVER-1488 turn off DecodeDeepZeroInline for mgocompat.Registry (mongodb#312)

* Fix primitive.Regex Equal method (mongodb#318)

* GODRIVER-1507 Correctly pass URI to topology (mongodb#320)

* Update version to 1.3.1

* Update version to v1.3.2+prerelease

* GODRIVER-1522 Ignore read preference for aggregations with output stages (mongodb#327)

* GODRIVER-1520 Fix panics for lone scope (mongodb#331)

* GODRIVER-1532 Remove check when decoding invalid UTF-8 strings (mongodb#333)

* Fix typo in objectid.go (mongodb#335)

* GODRIVER-1502 Fix variable shadowing in parsing (mongodb#332)

* GODRIVER-1506 Fix error checking for invalid extjson timestamp values (mongodb#337)

* GODRIVER-1504 Restrict top-level keys from being parsed as extjson (mongodb#340)

* GODRIVER-1513 Disallow escaped single quotes in extjson keys (mongodb#342)

* GODRIVER-1535 Fix session IDs batching in Disconnect

* GODRIVER-1540 fix deadlock in connection (mongodb#348)

* GODRIVER-1549 Select all servers when an empty tag set is given (mongodb#352)

* GODRIVER-1431 Add explicit encryption examples (mongodb#350)

* Update version to v1.3.2

* STITCH-4296: Export contextWithSession

* STITCH-4296: Export sessionFromContext

* STITCH-4680 - expose topology consistency

* STITCH-4841: Add FullDocumentBeforeChange option to Mongo-go-driver

* GODRIVER-672 Change session IDs to be stored as bson.Raw (mongodb#339)

(cherry picked from commit d080bd0)

* do not leak cancelConnectContext

* REALMC-5872 renaming NewSessionContext to ContextWithSession

* REALMC-5872 adding back size check in pool test

* REALMC-5872 removing unused IsConsistent topology function and renaming changed vars

Co-authored-by: Divjot Arora <[email protected]>
Co-authored-by: iwysiu <[email protected]>
Co-authored-by: mengskysama <[email protected]>
Co-authored-by: Luca(Wei) Chen <[email protected]>
Co-authored-by: Haley Owen <[email protected]>
Co-authored-by: Eric Daniels <[email protected]>
Co-authored-by: Tyler Kaye <[email protected]>
Co-authored-by: Jonathan Reams <[email protected]>
Co-authored-by: mike o'brien <[email protected]>
(cherry picked from commit c59bda0)

* REALMC-6991: add topology check

Co-authored-by: Kush Patel <[email protected]>
tsedgwick added a commit to mongodb-forks/mongo-go-driver that referenced this pull request Jun 1, 2021
@tsedgwick @kpatel71716
REALMC-8848: upgrade to latest go driver release (#4)
7ae91d3 
* REALMC-5872 merging topology changes to v1.4.1 driver (#1)

* Update version to v1.3.1+prerelease

* Change w value for unsatisfiable write concern in tests (mongodb#301)

- Addresses test failures that started after by SERVER-45920

* GODRIVER-895 check if strLength is 0 in ReadCodeWithScope (mongodb#311)

* GODRIVER-1487 fix adding UnknownTransactionCommitResult (mongodb#307)

* GODRIVER-1488 turn off DecodeDeepZeroInline for mgocompat.Registry (mongodb#312)

* Fix primitive.Regex Equal method (mongodb#318)

* GODRIVER-1507 Correctly pass URI to topology (mongodb#320)

* Update version to 1.3.1

* Update version to v1.3.2+prerelease

* GODRIVER-1522 Ignore read preference for aggregations with output stages (mongodb#327)

* GODRIVER-1520 Fix panics for lone scope (mongodb#331)

* GODRIVER-1532 Remove check when decoding invalid UTF-8 strings (mongodb#333)

* Fix typo in objectid.go (mongodb#335)

* GODRIVER-1502 Fix variable shadowing in parsing (mongodb#332)

* GODRIVER-1506 Fix error checking for invalid extjson timestamp values (mongodb#337)

* GODRIVER-1504 Restrict top-level keys from being parsed as extjson (mongodb#340)

* GODRIVER-1513 Disallow escaped single quotes in extjson keys (mongodb#342)

* GODRIVER-1535 Fix session IDs batching in Disconnect

* GODRIVER-1540 fix deadlock in connection (mongodb#348)

* GODRIVER-1549 Select all servers when an empty tag set is given (mongodb#352)

* GODRIVER-1431 Add explicit encryption examples (mongodb#350)

* Update version to v1.3.2

* STITCH-4296: Export contextWithSession

* STITCH-4296: Export sessionFromContext

* STITCH-4680 - expose topology consistency

* STITCH-4841: Add FullDocumentBeforeChange option to Mongo-go-driver

* GODRIVER-672 Change session IDs to be stored as bson.Raw (mongodb#339)

(cherry picked from commit d080bd0)

* do not leak cancelConnectContext

* REALMC-5872 renaming NewSessionContext to ContextWithSession

* REALMC-5872 adding back size check in pool test

* REALMC-5872 removing unused IsConsistent topology function and renaming changed vars

Co-authored-by: Divjot Arora <[email protected]>
Co-authored-by: iwysiu <[email protected]>
Co-authored-by: mengskysama <[email protected]>
Co-authored-by: Luca(Wei) Chen <[email protected]>
Co-authored-by: Haley Owen <[email protected]>
Co-authored-by: Eric Daniels <[email protected]>
Co-authored-by: Tyler Kaye <[email protected]>
Co-authored-by: Jonathan Reams <[email protected]>
Co-authored-by: mike o'brien <[email protected]>
(cherry picked from commit c59bda0)

* REALMC-6991: add topology check

Co-authored-by: Kush Patel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@divjotarora divjotarora Awaiting requested review from divjotarora

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mengskysama @divjotarora