GODRIVER-1469 ensure gridfs index checking supports indexes created i… #341
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
divjotarora
reviewed
Mar 20, 2020
There was a problem hiding this comment.
As a starting point, I'm finding the code for createIndexIfNotExists hard to read because the variable names get tricky when we do multiple BSON transformations. I think it would help if we added a new function called compareIndexDocs(expected, actual bsoncore.Document) that did both a bytes.Equal check as well as a semantic element-wise check. I want to get your opinion on this before continuing the review.
divjotarora
reviewed
Mar 20, 2020
divjotarora
reviewed
Mar 20, 2020
divjotarora
approved these changes
Mar 23, 2020
jyemin
requested changes
Mar 26, 2020
|
@iwysiu The "config file was invalid" error from Evergreen can be fixed by rebasing on master and force-pushing. The Evergreen team invalidated the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…n the shell