GODRIVER-1494 add option for encoding/json style map encoding #345
Conversation
|
Divjot and I talked, and we decided that it was less likely to be backwards breaking for users if we use our own interfaces instead of encoding/json's |
bson/bsoncodec/map_codec.go
Outdated
| return val.String(), nil | ||
| } | ||
| // KeyMarshalers are marshaled | ||
| if tm, ok := val.Interface().(KeyMarshaler); ok { |
There was a problem hiding this comment.
nit: I assume tm was for TextMarshaler. Change to km.
There was a problem hiding this comment.
Should we be checking if a pointer to value implements KeyMarshaler as well? Our standard registry lookup checks that for other interfaces we support like Marshaler.
There was a problem hiding this comment.
from what i can tell, map keys aren't addressable, so I didn't any of the pointer to value things.
There was a problem hiding this comment.
Yep, seems like encoding/json doesn't respect &T implementing TextMarshaler either. As discussed offline, this is likely because map keys and values can move around if the map is re-sized so any addresses to them would be invalidated.
No description provided.