GODRIVER-1642 add unknown server description constructor #417
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
divjotarora
reviewed
Jun 9, 2020
There was a problem hiding this comment.
-
The line that stores the initial description in
Server.Connectshould also be updated. In general, it'd be good to do a search fordescription.Serverintopology/server.goand replace any relevant lines to make sure we're never constructing a description manually. -
Because a server is set to
Unknownboth as the default when we haven't done any heartbeats and in response to an error, I think we should havedescription.NewDefaultServeranddescription.NewServerFromErrorconstructors. The first would be the same as callingdescription.NewUnknownServer(s.address, nil)but it's semantically different.
divjotarora
approved these changes
Jun 10, 2020
iwysiu
pushed a commit
that referenced
this pull request
Jun 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.