Skip to content

GODRIVER-761 Resync CRUD tests to use transactions test format #459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 29, 2020

Conversation

divjotarora
Copy link
Contributor

@divjotarora divjotarora commented Jul 17, 2020

This PR now includes a full resync of CRUD spec tests, both v1 and v2, and the changes required to fix the bugs in GODRIVER-1696.

@divjotarora divjotarora requested review from jyemin and iwysiu July 17, 2020 19:30
Copy link
Contributor

@jyemin jyemin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@divjotarora divjotarora force-pushed the godriver761-resync-crud-tests branch from 00decef to 7d782e6 Compare July 17, 2020 22:13
@divjotarora divjotarora requested a review from jyemin July 17, 2020 22:18
@divjotarora divjotarora force-pushed the godriver761-resync-crud-tests branch from 7d782e6 to 5caf11b Compare July 18, 2020 00:24
@divjotarora
Copy link
Contributor Author

@jyemin I requested a review from you because your initial review was just for the tests resync and did not include the bug fixes for GODRIVER-1696.

Copy link
Contributor

@jyemin jyemin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@divjotarora divjotarora merged commit 037df13 into mongodb:master Jul 29, 2020
@divjotarora divjotarora deleted the godriver761-resync-crud-tests branch July 29, 2020 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants