GODRIVER-1659 fail fast during server selection if incompatible WireVersion #461
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
divjotarora
reviewed
Jul 22, 2020
divjotarora
reviewed
Jul 22, 2020
divjotarora
reviewed
Jul 23, 2020
divjotarora
reviewed
Jul 24, 2020
divjotarora
approved these changes
Jul 24, 2020
iwysiu
approved these changes
Jul 24, 2020
KritiRav
deleted the
GODRIVER-1659-server-selection-error-for-incompatible-version
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.mongodb.org/browse/GODRIVER-1659
This pull request will ensure that if any server has an incompatible
WireVersion, it will fail fast during server selection and return the appropriate error in order to be consistent with the spec.