Skip to content

GODRIVER-1511 Test that SDAM flow is always run #464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 22, 2020
Merged

GODRIVER-1511 Test that SDAM flow is always run #464

merged 1 commit into from
Jul 22, 2020

Conversation

divjotarora
Copy link
Contributor

We were already running the SDAM flow for every new server description, regardless of equality, so the only changes here are spec test resyncs.

@divjotarora divjotarora requested review from jyemin and iwysiu July 21, 2020 21:43
jyemin
jyemin approved these changes Jul 21, 2020
View reviewed changes
Copy link
Contributor

@jyemin jyemin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@divjotarora divjotarora merged commit 8e154bb into mongodb:master Jul 22, 2020
@divjotarora divjotarora deleted the godriver1511-run-sdam-flow branch July 22, 2020 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jyemin jyemin jyemin approved these changes

@iwysiu iwysiu iwysiu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@divjotarora @jyemin @iwysiu