GODRIVER-1028 return correct error indexes for bulkWrite #483
Conversation
There was a problem hiding this comment.
My understanding of this change is that we store the original index of each model when creating batches and we use that information later on when creating error structs. Doing it this way also eliminates the need to keep the base index of the batch so we don't need to do something like index += baseIndex. Is that all correct?
Also, do we have a similar test case for ordered bulk writes?
| assert.Equal(mt, len(res.UpsertedIDs), 2, "expected 2 UpsertedIDs, got %v", len(res.UpsertedIDs)) | ||
| assert.Equal(mt, res.UpsertedIDs[1].(string), id1, "expected UpsertedIDs[1] to be %v, got %v", id1, res.UpsertedIDs[1]) | ||
| assert.Equal(mt, res.UpsertedIDs[3].(string), id3, "expected UpsertedIDs[3] to be %v, got %v", id3, res.UpsertedIDs[3]) | ||
| }) |
There was a problem hiding this comment.
I was also going to ask whether there are tests of individual commands being split into multiple batches. Though that was addressed in GODRIVER-1363 and appears to be tested in c814cfb#diff-1572fa8947f9463542abdc5cb3a11528R204.
There was a problem hiding this comment.
that will be handled in GODRIVER-1715
No description provided.