GODRIVER-1726 Fix SDAM error handling for write concern errors #489
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
August 21, 2020 11:45
iwysiu
approved these changes
Aug 24, 2020
kevinAlbs
approved these changes
Aug 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I took this ticket as an opportunity to add some integration tests for SDAM error handling. They now ensure that we correctly process NodeIsRecovering and NotMaster errors correctly when they're in an ok:0 or writeConcernError document. Unfortunately, each test takes ~0.5 seconds to run because of minHeartbeatFrequency, but I still think they're worth having. Also, we don't have SDAM monitoring, so we can't actually assert that the server was marked Unknown, but by testing on both 4.0 and 4.2, we can assert that the server's connection pool was cleared, which is at least enough to ensure that we're correctly entering the SDAM error handling code path.