Use Go 1.15 in Evergreen #492
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kevinAlbs @iwysiu Hold off on reviewing this for now. The test runs in Evergreen are actually failing because of inconsistent vendoring, but running |
This commit also fixes errors from "go vet" and "gofmt". GODRIVER-1729 GODRIVER-1730
|
@kevinAlbs @iwysiu This is ready for review now. |
kevinAlbs
approved these changes
Aug 28, 2020
iwysiu
approved these changes
Aug 31, 2020
divjotarora
pushed a commit
that referenced
this pull request
Aug 31, 2020
This commit also fixes errors from "go vet" and "gofmt". GODRIVER-1729 GODRIVER-1730
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I filed two separate tickets to use Go 1.15 in Evergreen and to fix vet/fmt errors for 1.15, but they're dependent on each other so I have them in one pull request. Once this is approved, we can figure out if we want to backport both or rebase/merge instead of squashing and just backport the vet/fmt fixes.