GODRIVER-1805 Add tests for unmarshalling BSON with undefined fields #552
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
divjotarora
reviewed
Dec 10, 2020
divjotarora
approved these changes
Dec 10, 2020
divjotarora
approved these changes
Dec 10, 2020
iwysiu
approved these changes
Dec 14, 2020
kevinAlbs
approved these changes
Dec 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GODRIVER-1805
Adds tests for unmarshalling BSON with undefined fields. Faulty behavior was recently discovered when unmarshalling extended JSON with undefined fields; this behavior was fixed in 1235, and test coverage was added. The same faulty behavior does not exist for BSON, but these tests should cover any theoretical
value_reader#Skip()errors.