Skip to content

Changed order of actions in ObjectIDFromHex func #637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 30, 2021
Merged

Changed order of actions in ObjectIDFromHex func #637

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2db57a9
Changed order of actions in ObejctIDFromHex func
Don2Quixote Apr 18, 2021
28bdfe1
Applied gofmt
Don2Quixote Apr 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions bson/primitive/objectid.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,15 +73,15 @@ func (id ObjectID) IsZero() bool {
// ObjectIDFromHex creates a new ObjectID from a hex string. It returns an error if the hex string is not a
// valid ObjectID.
func ObjectIDFromHex(s string) (ObjectID, error) {
if len(s) != 24 {
return NilObjectID, ErrInvalidHex
}

b, err := hex.DecodeString(s)
if err != nil {
return NilObjectID, err
}

if len(b) != 12 {
return NilObjectID, ErrInvalidHex
}

var oid [12]byte
copy(oid[:], b[:])

Expand Down