GODRIVER-2061 Test redaction of replies of security sensitive commands #703
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjirewis
requested review from
matthewdale and
kevinAlbs
and removed request for
matthewdale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GODRIVER-2061
Syncs the redacted commands spec tests. These tests have been updated to make a best effort at asserting that replies to security sensitive commands are redacted. The Go driver already has the correct behavior (reply redaction happens here), so no code changes are necessary.
Adds workaround for empty
Replyfields inverifyCommandEvents; it is almost identical to the existing workaround for emptyCommandfields here.