GODRIVER-2119 implement methods required to use as a map key #715
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjirewis
reviewed
Aug 12, 2021
There was a problem hiding this comment.
Thanks again for your contribution @Luberry ! Just some small comments.
benjirewis
approved these changes
Aug 12, 2021
matthewdale
approved these changes
Aug 16, 2021
| require.Equal(t, expectedJSON, out) | ||
| } | ||
|
|
||
| func TestObjectID_UnmarshalJSONMap(t *testing.T) { |
There was a problem hiding this comment.
Consider incorporating this test function as a test case in TestObjectID_UnmarshalJSON.
There was a problem hiding this comment.
I did not add it in TestObjectID_UnmarshalJSON because i did not see a clean way of slotting it into the table tests.
…mplements the interface
faem
pushed a commit
to kubedb/mongo-go-driver
that referenced
this pull request
Mar 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GODRIVER-2119
Implements the TextMarshaler and TextUnmarshaler methods on
primitive.ObjectIDto allow it to be used as a map key.