Skip to content

GODRIVER-2038 Make all connections in the background using connectTimeoutMS. #716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Oct 20, 2021
Merged

GODRIVER-2038 Make all connections in the background using connectTimeoutMS. #716

merged 13 commits into from
Oct 20, 2021

Conversation

matthewdale
Copy link
Collaborator

@matthewdale matthewdale commented Aug 6, 2021 •
edited
Loading

Refactor the Go driver connection pool to establish all new connections in background goroutines.

Changes:

  • Use connectTimeoutMS (default 30s) as the timeout for establishing all new connections.
  • Establish all new connections in background goroutines to separate the connection establishment deadline from the checkOut deadline.
  • Limit the number of new connections created simultaneously to 2 (maxConnecting).
  • Rename functions get() -> checkOut() and put() -> checkIn() to align with CMAP naming.
  • Always disconnect pools created in tests to prevent leaking goroutines and connections.

GODRIVER-2038
GODRIVER-2044

@matthewdale matthewdale force-pushed the godriver2038-background-conns-2 branch 3 times, most recently from 5f9e0d9 to 2def9ae Compare August 12, 2021 00:54
@matthewdale matthewdale force-pushed the godriver2038-background-conns-2 branch 8 times, most recently from 56a3a88 to 1530024 Compare August 24, 2021 20:30
@matthewdale matthewdale force-pushed the godriver2038-background-conns-2 branch 2 times, most recently from 633f69c to c546264 Compare August 24, 2021 23:36
@matthewdale matthewdale force-pushed the godriver2038-background-conns-2 branch 8 times, most recently from ffe57e8 to 6cc7f51 Compare September 7, 2021 23:17
@matthewdale matthewdale force-pushed the godriver2038-background-conns-2 branch 9 times, most recently from 4c6e87d to 184cf7d Compare September 10, 2021 17:21
divjotarora
divjotarora approved these changes Oct 15, 2021
View reviewed changes
Copy link
Contributor

@divjotarora divjotarora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@matthewdale matthewdale force-pushed the godriver2038-background-conns-2 branch 4 times, most recently from 6779ffe to 241b1e3 Compare October 18, 2021 19:48
kevinAlbs
kevinAlbs reviewed Oct 18, 2021
View reviewed changes
Copy link
Contributor

@kevinAlbs kevinAlbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Phenominal work. Looks good pending:

  • The removal of WaitQueueTimeoutMS in the PoolCreated event.
  • Rate limit of 10 connections in maintain.

@matthewdale matthewdale force-pushed the godriver2038-background-conns-2 branch 7 times, most recently from 39c03de to 94c9917 Compare October 19, 2021 22:58
matthewdale and others added 13 commits October 19, 2021 18:53
@matthewdale
GODRIVER-2038 Make all connections in the background using connectTim…
375e02c 
…eoutMS.
@matthewdale
Make disconnecting pools in tests easier and improve a CMAP prose test.
aedf872
@matthewdale
Improve max pool size logic and lock connsCond when cancelling the ba…
59b1737 
…ckground goroutines ctx.
@matthewdale @benjirewis
Correct CMAP prose test assertion message.
6705622 
Co-authored-by: Benjamin Rewis <[email protected]>
@matthewdale
Fix accidentally removed serverConnectionID assignment on handshake.
337ec80
@matthewdale @kevinAlbs
Update x/mongo/driver/topology/connection_test.go
e26553e 
Co-authored-by: Kevin Albertson <[email protected]>
@matthewdale @kevinAlbs
Apply suggestions from code review
af3b1e9 
Co-authored-by: Kevin Albertson <[email protected]>
@matthewdale @kevinAlbs @benjirewis
Apply suggestions from code review
9bee5cb 
Co-authored-by: Kevin Albertson <[email protected]>
Co-authored-by: Benjamin Rewis <[email protected]>
@matthewdale
Respond to review feedback and add comments to clarify confusion points.
c195560
@matthewdale
Respond to PR feedback.
ea4f951
@matthewdale
Enable ClientStressTest and fix pool test.
dbb3f1c
@matthewdale
Request max 10 connections at a time to satisfy minPoolSize and simpl…
8b5d898 
…ify disconnect().
@matthewdale
Fix TestClientStress test.
b0a6da0
@matthewdale matthewdale force-pushed the godriver2038-background-conns-2 branch from 94c9917 to b0a6da0 Compare October 20, 2021 01:53
kevinAlbs
kevinAlbs approved these changes Oct 20, 2021
View reviewed changes
Copy link
Contributor

@kevinAlbs kevinAlbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Reviewed the latest two commits for the stress test fix, requesting a max of 10 connections in maintain, and disconnect simplification. Nicely done.

@matthewdale matthewdale merged commit 8539500 into mongodb:master Oct 20, 2021
faem pushed a commit to kubedb/mongo-go-driver that referenced this pull request Mar 17, 2022
@matthewdale
GODRIVER-2038 Make all connections in the background using connectTim…
50f6ae1 
…eoutMS. (mongodb#716)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjirewis benjirewis benjirewis approved these changes

@kevinAlbs kevinAlbs kevinAlbs approved these changes

@divjotarora divjotarora divjotarora approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@matthewdale @kevinAlbs @divjotarora @benjirewis