GODRIVER-2136 Include LatencySelector in change stream server selector #720
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let me know if you think I should add an integration test here. I wasn't quite sure how to test that |
matthewdale
approved these changes
Aug 25, 2021
There was a problem hiding this comment.
Looks good, pending passing of the Atlas Test.
As far as adding an integration test, I wasn't able to find any example of an integration test that asserts on the LatencySelector behavior, so I don't have an idea of how to do that either. I think it's fine without that integration test for now.
|
The failing atlas test is due to expired certificates from Atlas. See GODRIVER-2128 and its dependency CLOUDP-97605. |
benjirewis
added a commit
that referenced
this pull request
Aug 30, 2021
faem
pushed a commit
to kubedb/mongo-go-driver
that referenced
this pull request
Mar 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GODRIVER-2136
Modifies the
selectorfor newChangeStreaminstances innewChangeStreamto be aCompositeSelectorof aReadPrefSelectorand aLatencySelector. This should make it so change stream server selection (both in creation and resumption) will respect theClient'sLocalThresholdvalue.