GODRIVER-2133 Error on semantic single documents as aggregate pipelines #721
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjirewis
commented
Aug 24, 2021
matthewdale
reviewed
Aug 30, 2021
benjirewis
added a commit
that referenced
this pull request
Sep 1, 2021
faem
pushed a commit
to kubedb/mongo-go-driver
that referenced
this pull request
Mar 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GODRIVER-2133
Modifies
transformAggregatePipelineto error if the providedpipelineis a non-empty semantically a single document (bson.D,bson.Raw,bsoncore.Document) but is implemented as a slice. This will stop users from passing something likebson.D{{"x", 1}}as a pipeline since it is not strictly speaking an array of documents and give them an informative error message.