GODRIVER-2085 Add serverConnectionId to command monitoring events #724
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjirewis
commented
Aug 30, 2021
kevinAlbs
reviewed
Aug 30, 2021
kevinAlbs
reviewed
Sep 3, 2021
benjirewis
commented
Sep 14, 2021
There was a problem hiding this comment.
I've removed ServerConnectionID from description.Server and added it to HandshakeInformation.
I also required a new field serverConnectionID on topology.Connection and a new method on the Connection interface: ServerConnectionID. The new ServerConnectionID method means that any user implementing driver.Connection will see an error (this interface is under x, though).
kevinAlbs
reviewed
Sep 15, 2021
kevinAlbs
approved these changes
Sep 15, 2021
matthewdale
approved these changes
Sep 15, 2021
added 7 commits
September 16, 2021 11:50
|
Failing tests are just due to GODRIVER-2155. |
faem
pushed a commit
to kubedb/mongo-go-driver
that referenced
this pull request
Mar 17, 2022
…ngodb#724) Bump UTF schema version to 1.6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GODRIVER-2085
Adds a
ServerConnectionIDfield toCommandStartedEvent,CommandSucceededEventandCommandFailedEventto track theserverConnectionIdreturned in the server'shelloor legacy hello response (on 4.2+). Syncs command monitoring spec tests. Bumps supported schema version of the unified test runner to 1.6.