-
Notifications
You must be signed in to change notification settings - Fork 911
GODRIVER-2169 Use perf.send instead of json.send #772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good! Is there a successful run of a perf
task with the new changes? I have reconfigured the attached patch build to include the perf
task: https://spruce.mongodb.com/task/mongo_go_driver_perf_perf_patch_8a397a401000e6ba266e8a18beabc8af4da4a773_616f31e63e8e8608fdd848e8_21_10_19_21_00_24/logs?execution=0
Looks like the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! The table on the perf task looks good.
GODRIVER-2169
The TIPS team recently switched to a more robust performance gathering tool
perf.send
. Updates our usage ofjson.send
toperf.send
and modifies the output ofEvergreenPerfFormat()
as described here. (I separately gave themongodb-signal-processing-bot
read access to this repo).The format of the data used by
json.send
was:The format of the data now used by
perf.send
is: