GODRIVER-2083: Test serialization of BSON with embedded null bytes in strings #784
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjirewis
suggested changes
Nov 1, 2021
kevinAlbs
reviewed
Nov 2, 2021
There was a problem hiding this comment.
Looks great!
I think one more case in the prose tests is required.
I suggest adding to the tests added in GODRIVER-1923:
- TestNullBytes in bson/marshal_test.go
- TestNullBytes in x/bsonx/bsoncore/bsoncore_test.go
Those have cases for embedded NULL bytes, but I think need the case Field name within a sub-document.
benjirewis
suggested changes
Nov 3, 2021
benjirewis
approved these changes
Nov 3, 2021
gabbyasuncion
added a commit
to gabbyasuncion/mongo-go-driver
that referenced
this pull request
Nov 18, 2021
faem
pushed a commit
to kubedb/mongo-go-driver
that referenced
this pull request
Mar 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GODRIVER-2083
Syncs Go Driver BSON corpus spec tests with those indicated here. Also updates BSON corpus spec test to validate null bytes when encoding JSON to BSON and to raise the expected error (as done here).