Skip to content

GODRIVER-2156 Enable unparam linter. #802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 30, 2021
Merged

GODRIVER-2156 Enable unparam linter. #802

merged 1 commit into from
Nov 30, 2021

Conversation

matthewdale
Copy link
Collaborator

Enable the unparam linter and remove unused function parameters.

@matthewdale matthewdale force-pushed the godriver2156-enable-linters-unparam branch from 6b3f926 to 1846a70 Compare November 18, 2021 22:56
benjirewis
benjirewis approved these changes Nov 19, 2021
View reviewed changes
Copy link
Contributor

@benjirewis benjirewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for all the additional cleanup beyond just removing the unused parameters.

kevinAlbs
kevinAlbs approved these changes Nov 21, 2021
View reviewed changes
Copy link
Contributor

@kevinAlbs kevinAlbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a suggested addition for the MinTLSVersion change as part of a separate PR.

@matthewdale matthewdale force-pushed the godriver2156-enable-linters-unparam branch from 1846a70 to a35cda3 Compare November 29, 2021 20:15
@matthewdale
Copy link
Collaborator Author

One failing test is due to DRIVERS-1991. Merging.

@matthewdale matthewdale merged commit 2bc145d into mongodb:master Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinAlbs kevinAlbs kevinAlbs approved these changes

@benjirewis benjirewis benjirewis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matthewdale @kevinAlbs @benjirewis