Skip to content

GODRIVER-2247 Add missing comments to exported functions/types #823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 30, 2021
Merged

GODRIVER-2247 Add missing comments to exported functions/types #823

merged 1 commit into from
Nov 30, 2021

Conversation

benjirewis
Copy link
Contributor

GODRIVER-2247

Adds missing (and fixes malformed) comments of exported functions/types across the repo. golint was complaining on older branches.

@benjirewis benjirewis requested a review from kevinAlbs November 30, 2021 22:46
@benjirewis benjirewis marked this pull request as ready for review November 30, 2021 22:46
kevinAlbs
kevinAlbs approved these changes Nov 30, 2021
View reviewed changes
Copy link
Contributor

@kevinAlbs kevinAlbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! This seems like an overall improvement regardless of fixing golint.

@benjirewis
Copy link
Contributor Author

Failing test is due to GODRIVER-2242.

@benjirewis benjirewis merged commit 66dad3a into mongodb:master Nov 30, 2021
@benjirewis benjirewis deleted the operationPackageComments branch November 30, 2021 23:06
benjirewis added a commit that referenced this pull request Dec 1, 2021
@benjirewis
GODRIVER-2247 Add missing comments to exported functions/types (#823)
20a317b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinAlbs kevinAlbs kevinAlbs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benjirewis @kevinAlbs