GODRIVER-1824 Test that Client waits 500ms between failed Hellos #838
Conversation
| }, | ||
| Data: mtest.FailPointData{ | ||
| FailCommands: []string{internal.LegacyHello, "hello"}, | ||
| ErrorCode: 1234, |
There was a problem hiding this comment.
Is this error code important, or can it be any value?
There was a problem hiding this comment.
Could be any value I think. 1234 was just a placeholder from the spec tests. I could remove it since we don't assert anything about the error code, but I'll probably just leave it in for consistency with other drivers.
There was a problem hiding this comment.
Ah, I didn't realize that value came directly from the prose test. Should we consider adding links to the relevant prose test or the GODRIVER ticket to keep a record of what tests cover what prose tests?
There was a problem hiding this comment.
The GODRIVER ticket already links to a DRIVERS ticket with the specified prose test. However, I do think our prose tests could be better labeled/numbered, so I filed GODRIVER-2274. Probably out of scope for this PR, though.
| @@ -108,4 +108,34 @@ func TestSDAMProse(t *testing.T) { | |||
| assert.Soon(t, callback, defaultCallbackTimeout) | |||
| }) | |||
| }) | |||
|
|
|||
| mt.RunOpts("client waits between failed Hellos", mtest.NewOptions().MinServerVersion("4.9").Topologies(mtest.Single), func(mt *mtest.T) { | |||
There was a problem hiding this comment.
Only running this test against standalones since it's using DirectConnection: true which will error against replica sets and sharded clusters.
| }, | ||
| Data: mtest.FailPointData{ | ||
| FailCommands: []string{internal.LegacyHello, "hello"}, | ||
| ErrorCode: 1234, |
There was a problem hiding this comment.
Ah, I didn't realize that value came directly from the prose test. Should we consider adding links to the relevant prose test or the GODRIVER ticket to keep a record of what tests cover what prose tests?
GODRIVER-1824
Implement the prose test described in DRIVERS-1251. This test verifies that the driver waits approximately 500ms between failing hellos and legacy hellos.