Replace all uses of mtest.Background with context.Background() #839
Conversation
| @@ -4,6 +4,7 @@ | |||
| // not use this file except in compliance with the License. You may obtain | |||
| // a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 | |||
|
|
|||
| //go:build cse | |||
There was a problem hiding this comment.
Was this intended to be included?
Regardless, adding go:build cse seems OK to add based on https://stackoverflow.com/a/68361186/774658.
There was a problem hiding this comment.
Ah, good find! That wasn't intended to be included. As the linked article suggests, looks like it's automatically added by gofmt if you're using Go 1.17+.
Since it's the official Go formatter adding those and they're backwards-compatible with previous Go versions, I think we should keep them.
| @@ -4,6 +4,7 @@ | |||
| // not use this file except in compliance with the License. You may obtain | |||
| // a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 | |||
|
|
|||
| //go:build go1.13 | |||
There was a problem hiding this comment.
Is this intended to be included?
There was a problem hiding this comment.
See above. Not intentional, but I think we should keep it.
| @@ -4,6 +4,7 @@ | |||
| // not use this file except in compliance with the License. You may obtain | |||
| // a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 | |||
|
|
|||
| //go:build go1.13 | |||
There was a problem hiding this comment.
See above. Not intentional, but I think we should keep it.
matthewdale
force-pushed
the
experiment_mtest_background
branch
from
49bd910 to
9699359
Compare
There is currently an inconsistent mixture between use of
context.Background()andmtest.Backgroundcontext values in tests. Those two values are semantically and functionally identical, butmtest.Backgroundrequires additional knowledge of what that value is, wherecontext.Background()is a more generally understood stdlib value.Replace all uses of
mtest.Backgroundwithcontext.Background()and remove themtest.Backgroundvalue.