GODRIVER-2337 Add CustomPipeline to ChangeStreamOptions #880
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjirewis
commented
Mar 21, 2022
| @@ -58,7 +58,7 @@ type AggregateOptions struct { | |||
| // Custom options to be added to aggregate expression. Key-value pairs of the BSON map should correlate with desired | |||
| // option names and values. Values must be Marshalable. Custom options may conflict with non-custom options, and custom | |||
| // options bypass client-side validation. Prefer using non-custom options where possible. | |||
| CustomOptions bson.M | |||
| Custom bson.M | |||
There was a problem hiding this comment.
Also changed CustomOptions to Custom in AggregateOptions for consistency.
prestonvasquez
approved these changes
Mar 21, 2022
prestonvasquez
added a commit
that referenced
this pull request
Mar 21, 2022
This reverts commit 6cb4f98.
benjirewis
added a commit
that referenced
this pull request
Mar 21, 2022
This reverts commit 6cb4f98.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GODRIVER-2337
Renames
ChangeStreamOptions.CustomOptions(abson.Mwith marshalable values to be passed to the initial aggregate) toChangeStreamOptions.Custom. Adds aChangeStreamOptions.CustomPipeline(also a bson.M) to be passed to$changeStreamstage within the initial aggregate pipeline. Adds an integration test forCustomPipeline.