GODRIVER-2310 Add snapshot query examples #887
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prestonvasquez
changed the title
benjirewis
suggested changes
Mar 24, 2022
matthewdale
reviewed
Mar 25, 2022
matthewdale
approved these changes
Mar 25, 2022
kevinAlbs
reviewed
Mar 28, 2022
There was a problem hiding this comment.
Nicely done. The additional assertions outside of the example comments will help catch bugs. Wrapping the example functions in separate t.Run calls helps to run the individual tests locally.
Suggested a change that may resolve the test failure in StableAPIStrictCountExample.
benjirewis
approved these changes
Mar 29, 2022
| _, err := catColl.InsertMany(context.Background(), []interface{}{ | ||
| bson.D{ | ||
| {"adoptable", false}, | ||
| {"name", "Miyagi"}, |
There was a problem hiding this comment.
Is one of these the name of your cat haha
There was a problem hiding this comment.
Miyagi is the name the shelter gave my cat, but I call him Mo :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GODRIVER-2310
TestDocumentationExamplesinto subtests per POC subtestWrapper #885mtestusage indocumentation_examples_testpackage