Remove unused ServerOption error. #888
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjirewis
approved these changes
Mar 28, 2022
prestonvasquez
approved these changes
Mar 29, 2022
matthewdale
force-pushed
the
experiment-remove-serveropts-err
branch
from
215b687 to
40ff6ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type
ServerOptionis currently afunc(*serverConfig) error. However, noServerOptionfunctions return an error. Remove the error returned by theServerOptiontype (nowfunc(*serverConfig)) and remove all of the now-unnecessary error handling logic.Follow up to previous similar PR #859