Fixed HHVM-178: Throw exception if Binary subtype is out of range

derickr · derickr · commit 64a9745a0ca2 · 2016-02-29T12:13:50.000Z
diff --git a/ext_mongodb.php b/ext_mongodb.php
@@ -657,6 +657,10 @@ final class Binary implements Type, \Serializable
 
 	public function __construct(private string $data, private int $type)
 	{
+		if ( $type < 0 || $type > 255 )
+		{
+			throw new \MongoDB\Driver\Exception\InvalidArgumentException( "Expected type to be an unsigned 8-bit integer, {$type} given" );
+		}
 	}
 
 	public function getType()

Original file line number	Diff line number	Diff line change
`@@ -657,6 +657,10 @@ final class Binary implements Type, \Serializable`
`657`	`657`
`658`	`658`	`public function __construct(private string $data, private int $type)`
`659`	`659`	`{`
	`660`	`+ if ( $type < 0 \|\| $type > 255 )`
	`661`	`+ {`
	`662`	`+ throw new \MongoDB\Driver\Exception\InvalidArgumentException( "Expected type to be an unsigned 8-bit integer, {$type} given" );`
	`663`	`+ }`
`660`	`664`	`}`
`661`	`665`
`662`	`666`	`public function getType()`