Skip to content
This repository was archived by the owner on Dec 23, 2021. It is now read-only.

HHVM-266: Javascript should emit $code/$scope for JSON #153

Merged
merged 2 commits into from
Nov 16, 2016
Merged

HHVM-266: Javascript should emit $code/$scope for JSON #153

merged 2 commits into from
Nov 16, 2016

Conversation

jmikola
Copy link
Member

@jmikola jmikola commented Nov 8, 2016 •
edited
Loading

derickr
derickr approved these changes Nov 16, 2016
View reviewed changes
Copy link
Contributor

@derickr derickr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, as long as you fix the test's title.

tests/json-serialize-javascript-002.phpt
@@ -1,9 +1,9 @@
--TEST--
JsonSerializable: Javascript
JsonSerializable: Javascript (with scope)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is without scope.

@jmikola jmikola merged commit 6660c80 into mongodb:v1.2 Nov 16, 2016
@jmikola jmikola deleted the 1.2-hhvm-266 branch November 16, 2016 18:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@derickr derickr derickr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmikola @derickr