This repository was archived by the owner on Dec 23, 2021. It is now read-only.
HHVM-196: Manager::getServers() should use mongoc_client_get_server_descriptions() #78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derickr
force-pushed
the
HHVM-196-manager-get-servers
branch
2 times, most recently
from
ce7496d to
46358c5
Compare
| sds = mongoc_client_get_server_descriptions(data->m_client, &n); | ||
| for (i = 0; i < n; i++) { | ||
| if (sds[i]->type == MONGOC_SERVER_UNKNOWN) { | ||
| continue; |
There was a problem hiding this comment.
I assume that mongodb_driver_add_server_debug_wrapper() never excluded servers in the unknown state, so this is a behavioral change. That said, it's probably quite insignificant.
There was a problem hiding this comment.
Correct, but by not skipping it, a test failed.
…lient_get_server_descriptions()
derickr
force-pushed
the
HHVM-196-manager-get-servers
branch
from
46358c5 to
acd7334
Compare
derickr
added a commit
that referenced
this pull request
Mar 30, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Can't really merge this yet until libmongoc 1.4.0 has been properly released.