Skip to content
This repository was archived by the owner on Dec 23, 2021. It is now read-only.

HHVM-203, HHVM-204, HHVM-205: Upgrade libmongoc to 1.4.0 with changes so that it compiles #79

Closed
wants to merge 3 commits into from

Conversation

derickr
Copy link
Contributor

@derickr derickr commented Mar 23, 2016

No description provided.

@jmikola
Copy link
Member

jmikola commented Mar 23, 2016

LGTM. Were you going to cut a v1.1 branch before merging?

For the record, I still think the following includes are unnecessary if you're not using Native Transport, despite the fact that they have #ifdef blocks:

  • mongoc-crypto-common-crypto.c
  • mongoc-rand-common-crypto.c
  • mongoc-secure-transport.c
  • mongoc-stream-tls-secure-transport.c

@derickr derickr force-pushed the HHVM-205-libmongoc-1.4.0 branch from 4279917 to cd9b164 Compare March 23, 2016 17:45
derickr added a commit that referenced this pull request Mar 24, 2016
@derickr derickr closed this Mar 24, 2016
@derickr derickr deleted the HHVM-205-libmongoc-1.4.0 branch March 24, 2016 15:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants