-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Add unified, legacy, and prose tests for CSFLE multi-KMS support. #1424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
/** | ||
* See <a href="https://github.com/mongodb/specifications/tree/master/source/client-side-encryption/tests#11-kms-tls-options-tests"> | ||
* 11. KMS TLS Options Tests</a>. | ||
*/ | ||
@Test() | ||
public void testThatCustomSslContextIsUsed() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A new use-case related to named providers was recently added to the KMS TLS Options specification prose tests. While the existing test testThatCustomSslContextIsUsed
for KMS TLS Options does not precisely align with the spec tests, it has been purposefully designed for simplicity achieving the desired effect. In line with the approach discussed in this original comment, this test has been extended to include named providers.
driver-sync/src/test/functional/com/mongodb/client/unified/UnifiedClientEncryptionHelper.java
Outdated
Show resolved
Hide resolved
driver-sync/src/test/functional/com/mongodb/client/unified/UnifiedClientEncryptionHelper.java
Outdated
Show resolved
Hide resolved
driver-sync/src/test/functional/com/mongodb/client/unified/UnifiedClientEncryptionHelper.java
Outdated
Show resolved
Hide resolved
...ctional/com/mongodb/client/AbstractClientSideEncryptionAwsCredentialFromEnvironmentTest.java
Outdated
Show resolved
Hide resolved
...ctional/com/mongodb/client/AbstractClientSideEncryptionAwsCredentialFromEnvironmentTest.java
Outdated
Show resolved
Hide resolved
...ctional/com/mongodb/client/AbstractClientSideEncryptionAwsCredentialFromEnvironmentTest.java
Outdated
Show resolved
Hide resolved
...ctional/com/mongodb/client/AbstractClientSideEncryptionAwsCredentialFromEnvironmentTest.java
Outdated
Show resolved
Hide resolved
...ctional/com/mongodb/client/AbstractClientSideEncryptionAwsCredentialFromEnvironmentTest.java
Outdated
Show resolved
Hide resolved
driver-sync/src/test/functional/com/mongodb/client/unified/UnifiedClientEncryptionHelper.java
Outdated
Show resolved
Hide resolved
driver-sync/src/test/functional/com/mongodb/client/unified/UnifiedClientEncryptionHelper.java
Outdated
Show resolved
Hide resolved
JAVA-5275
Summary
This PR implements the changes described in the "Downstream Changes Summary" of DRIVERS-2731.
NOTE: No changes to the CSFLE API are necessary, as it is forward-compatible because of using Map AutoEncryptionSettings.java#L126). All relevant logic is encapsulated within
libmongocrypt
. This PR builds on the updated dependency ofmongocrypt version 1.10.0-SNAPSHOT
which was updated in PR 1406.Background
Named KMS providers is further described in DBX Scope: Support Named KMS Providers.
The KMS provider identified by a string. Previously supported KMS providers were only: "aws", "azure", "gcp", "kmip", and "local". The KMS provider is now expanded to support name suffixes. (e.g. "local:myname").
Named KMS providers enables more than one of each KMS provider type to be configured.