This repository was archived by the owner on Feb 28, 2025. It is now read-only.
PHPLIB-1334 Add tests on Logical Query Operators #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GromNaN
commented
Jan 11, 2024
| { | ||
| "price": { | ||
| "$ne": { | ||
| "$numberDouble": "1.9899999999999999911" |
There was a problem hiding this comment.
The yaml 1.99 is encoded as { "$numberDouble": "1.9899999999999999911" }
echo MongoDB\BSON\Document::fromPHP(['x' => 1.99])->toCanonicalExtendedJSON();
// { "x" : { "$numberDouble" : "1.9899999999999999911" } }
There was a problem hiding this comment.
We could also deviate from the suggested value and choose a value that doesn't have this problem and can be represented exactly (e.g. 0.2).
There was a problem hiding this comment.
This is not an issue, as the value is always encoded the same way. But it can make tests to fail if we fix this behavior in a future version of the extension.
Tracking in PHPC-2341
Other example: #22 (comment)
alcaeus
approved these changes
Jan 12, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix PHPLIB-1334
https://www.mongodb.com/docs/manual/reference/operator/query/#logical
$and$not(using the syntax, as there is no example)$nor$or