This repository was archived by the owner on Feb 28, 2025. It is now read-only.
PHPLIB-1337 Add tests on Geospatial Query Operators #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GromNaN
commented
Jan 15, 2024
alcaeus
approved these changes
Jan 16, 2024
| $result->{'$' . $key} = $this->recursiveEncode($val); | ||
| $val = $this->recursiveEncode($val); | ||
|
|
||
| if ($key === 'geometry') { |
There was a problem hiding this comment.
We may want to consider introducing a special encoder for geo operators to extract this special logic.
There was a problem hiding this comment.
For everything related to geometry, we need to be compatible with a GeoJSON library instead of creating a $geometry object.
There was a problem hiding this comment.
I agree. Apart from a couple of libraries that saw their last updates 9 years ago, the only PHP libraries are found are jmikola/geojson which is supported in Doctrine ODM, and brick/geo which is still in a pre-release (0.x) state but saw its last update a little more than a year ago. I'll defer to @jmikola's expertise on this.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix PHPLIB-1337
https://www.mongodb.com/docs/manual/reference/operator/query/#geospatial
$geoIntersects$geoWithin$nearskipped "legacy coordinate", not supported$nearSphereskipped "legacy coordinate", not supported